Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[README Enhancement]: Children vs Adults Classification #535

Merged
merged 3 commits into from
May 12, 2024

Conversation

vanshikab52
Copy link
Contributor

Pull Request for DL-Simplified 💡

Issue Title : [README Enhancement]: Children vs Adults Classification

Closes: #525

Describe the add-ons or changes you've made 📃

Improved the README.md after understanding the project idea along with upscaled the results images and aligned them.

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

Describe how it has been tested
Describe how have you verified the changes made

Checklist: ☑️

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Copy link

Our team will soon review your PR. Thanks @vanshikab52 :)

@abhisheks008
Copy link
Owner

Hi @vanshikab52 you did a great job. Can you enhance the Dataset/README.md file too of this project?

@vanshikab52
Copy link
Contributor Author

Hi @vanshikab52 you did a great job. Can you enhance the Dataset/README.md file too of this project?

Yes sir I can modify it aswell. It's my pleasure to contribute to your project sir!

@vanshikab52
Copy link
Contributor Author

Hi @vanshikab52 you did a great job. Can you enhance the Dataset/README.md file too of this project?

Yes sir I can modify it aswell. It's my pleasure to contribute to your project sir!

@abhisheks008 is there any template you want the dataset README like to be or any changes you would suggest.

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go! Your PR is approved and ready to be merged.

@abhisheks008 abhisheks008 added documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers Status: Approved Approved PR by the PA. level 1 Level 1 for GSSOC and removed Status: Review Ongoing labels May 12, 2024
@abhisheks008 abhisheks008 merged commit 77516dc into abhisheks008:main May 12, 2024
@vanshikab52 vanshikab52 deleted the Update_README branch May 23, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers gssoc Girlscript Summer of Code 2024 level 1 Level 1 for GSSOC Points Updated Status: Approved Approved PR by the PA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[README Enhancement]: Children vs Adults Classification
2 participants