DeskTop: More internal API tidying

* Add UpdateActivateAndRefreshSelectedWindow * Rename proc to RemoveWindowFileRecords * Inline InitCachedWindowEntries * Rename proc to GetWindowPtr * Consolidate lib includes * Rename various procs used for populating windows * Shave bytes in IsControlChar No functional changes. Saves 8 bytes.
a2stuff · Jan 26, 2025 · 416e8c1 · 416e8c1
1 parent 989f0db
commit 416e8c1
Show file tree

Hide file tree

Showing 4 changed files with 75 additions and 83 deletions.
diff --git a/desk.acc/change.type.s b/desk.acc/change.type.s
@@ -355,8 +355,7 @@ cursor_ibeam_flag: .byte   0
         bcs     yes
 
         cmp     #' '
-        bcc     yes
-        rts                     ; C=1
+        rts                     ; C=0 (if less) or 1
 
 yes:    clc                     ; C=0
         rts

diff --git a/desk.acc/find.files.s b/desk.acc/find.files.s
@@ -299,8 +299,7 @@ ignore:
         bcs     yes
 
         cmp     #' '
-        bcc     yes
-        rts                     ; C=1
+        rts                     ; C=0 (if less) or 1
 
 yes:    clc                     ; C=0
         rts

diff --git a/desktop/init.s b/desktop/init.s
@@ -1100,11 +1100,11 @@ loop:   ldy     #0
 
         lda     #$80
         sta     main::copy_new_window_bounds_flag
-        sta     main::OpenDirectoryImpl::suppress_error_on_open_flag
+        sta     main::CreateFileRecordsForWindowImpl::suppress_error_on_open_flag
         jsr     _MaybeOpenWindow
         lda     #0
         sta     main::copy_new_window_bounds_flag
-        sta     main::OpenDirectoryImpl::suppress_error_on_open_flag
+        sta     main::CreateFileRecordsForWindowImpl::suppress_error_on_open_flag
 
 next:   jsr     PopPointers