DeskTop: Rework and simplify Get Info dialog logic

This dialog was implemented in an "interesting" way where each value was drawn by preparing a string in the initiating proc, then drawing it by jumping into a generic UI proc. This resulted in a lot of state updating for no real benefit. The theory of distinguishing the model and view is fine... but the whole GET_FILE_INFO struct can be considered the model. The whole lifecycle of the dialog is reworked. Doing it in a straightforward way dramatically simplifies the code and saves a bunch of bytes too. No functional changes. Saves 169 bytes.
a2stuff · Jan 26, 2025 · 170c1a0 · 170c1a0
1 parent 416e8c1
commit 170c1a0
Show file tree

Hide file tree

Showing 2 changed files with 135 additions and 205 deletions.
diff --git a/desktop/desktop.s b/desktop/desktop.s
@@ -31,7 +31,7 @@
         DEFSEG SegmentLoader,      $2000, $0200
         DEFSEG SegmentDeskTopAux,  $4000, $8000
         DEFSEG SegmentDeskTopLC,   $D000, $2100
-        DEFSEG SegmentDeskTopMain, $4000, $7800
+        DEFSEG SegmentDeskTopMain, $4000, $7700
         DEFSEG SegmentInitializer, $0800, $0900
         DEFSEG SegmentInvoker,     $0290, $0160