Update README with eth_getUncle* implementation status (#816)

These were implemented a while ago, but we forgot to update the supported APIs list.
Zilliqa · Apr 8, 2024 · 9e8166d · 9e8166d
1 parent e69eb5a
commit 9e8166d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/README.md b/README.md
@@ -80,10 +80,10 @@ Please open an issue or PR for APIs that you think should be included.
 | `eth_getTransactionByHash`                | 🟢                                              |
 | `eth_getTransactionCount`                 | 🟢                                              |
 | `eth_getTransactionReceipt`               | 🟢                                              |
-| `eth_getUncleByBlockHashAndIndex`         | 🔴                                              |
-| `eth_getUncleByBlockNumberAndIndex`       | 🔴                                              |
-| `eth_getUncleCountByBlockHash`            | 🔴                                              |
-| `eth_getUncleCountByBlockNumber`          | 🔴                                              |
+| `eth_getUncleByBlockHashAndIndex`         | 🟢                                              |
+| `eth_getUncleByBlockNumberAndIndex`       | 🟢                                              |
+| `eth_getUncleCountByBlockHash`            | 🟢                                              |
+| `eth_getUncleCountByBlockNumber`          | 🟢                                              |
 | `eth_newFilter`                           | 🔴                                              |
 | `eth_newBlockFilter`                      | 🔴                                              |
 | `eth_newPendingTransactionFilter`         | 🔴                                              |

diff --git a/zilliqa/src/api/eth.rs b/zilliqa/src/api/eth.rs
@@ -760,7 +760,6 @@ fn left_pad_arr<const N: usize>(v: &[u8]) -> Result<[u8; N]> {
     Ok(arr)
 }
 
-// These are no-ops basically
 fn get_uncle_count(_: Params, _: &Arc<Mutex<Node>>) -> Result<String> {
     Ok("0x0".to_string())
 }
-Original file line number
+Diff line change
@@ Expand Up @@
         Ok(arr)
     }
-    // These are no-ops basically
     fn get_uncle_count(_: Params, _: &Arc<Mutex<Node>>) -> Result<String> {
         Ok("0x0".to_string())
     }
@@ Expand Down @@