Fixed source code warnings because of iOS 8 checks #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @apouche, thanks for the patch! I'm curious if there is a way we can do this with compiler directives rather than removing the method entirely. I'm all for removing dead code, but just want to be sure we are comfortable with the build tools and deployment target versions that this might deprecate. We'll leave this open for now and talk it over. Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've removed the
registerForRemoteNotificationTypeshelper because it wasn't used in the app and I've fixed a warning that was occurring when compiling the source code directly in a binary target on iOS 8 targets.Let me know if you have any questions.