Issue #493: change IDL generation replacing //@top-level with @nested #495
Conversation
Signed-off-by: Ernesto Posse <eposse.gmail.com>
|
Resolves #493 |
| extensibility = "@appendable"; | ||
| } | ||
| buf.append(String.format("%s%s%n", indentString, extensibility)); | ||
| String nestedAnnotation = "@nested(FALSE)"; | ||
| if (!nested) { |
There was a problem hiding this comment.
This logic is confusing to me. While it might get the same result, I would rather the lines above, 346 & 347 reflect this inverse logic. i.e "If topLevel.matches("true") then nested = false" and visa-versa. Then the logic here can be simpler "If(nested) then annotation = "@nested(TRUE)""
There was a problem hiding this comment.
I've updated the logic, and added it to the AtcdWriter as well. I don't know if you are using that, but I figured it's probably best to keep those two generators in sync. Let me know if that's not ok. I'll cherry pick the change for v3.
There was a problem hiding this comment.
Yes, this logic looks good to me. We are not using ATCD anymore, but until we (or your team) decide to pull support for ATCD, you are right, we should keep them in sync
There was a problem hiding this comment.
ATCD has no support for @nested, it only has support for @top-level so you couldn't keep the version for AXCIOMA and ATCD in sync with respect to this annotation
There was a problem hiding this comment.
Oh. Ok, I'll retract the changes for ATCD.
Signed-off-by: Ernesto Posse <eposse.gmail.com>
Signed-off-by: Ernesto Posse <eposse.gmail.com>
No description provided.