fix: Stop using displaydoc
#8614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is unrelated to the solution in this branch. There's a new lint that produces a warning when lists in comments are not aligned well.
github-actions
bot
added
the
extra-reviews
|
An alternative solution would be to use the branch of |
arya2
approved these changes
Jun 17, 2024
There was a problem hiding this comment.
This looks good, thank you!
An alternative solution would be to use the branch of
displaydoccontaining the fix until it gets merged.
That may cause issues when we're publishing crates for the next version of Zebra, I like that we're removing a scarcely used dependency, though displaydoc also looks very nice if we want to add it back later and use it more.
|
Displaydoc 0.2.5 was published (yaahc/displaydoc#51), if you wish to go back to mainline displaydoc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Rust beta now contains a new lint (rust-lang/rust#120393) which produces a bunch of compilation warnings in the CI. They all come from
displaydoc(https://github.com/yaahc/displaydoc) which has an open PR (yaahc/displaydoc#47) containing a trivial fix for the issue but hasn't been merged in more than two months.Solution
displaydoc.fmt::Displaymanually for types that used to usedisplaydoc.Tests
The solution doesn't need tests.
PR Author's Checklist
The PR provides a CHANGELOG summary.The solution is tested.PR Reviewer's Checklist