Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] inject env vars to launch options with steam format %command% #749

Merged
merged 5 commits into from
Jan 28, 2025

Conversation

silentrald
Copy link
Contributor

@silentrald silentrald commented Jan 20, 2025

Issue described in discord, blocked by #745

Notes:

  • implemented a generic env parsers that is very similar to how steam handle theirs.
  • also added generic error message that can be display generic error messages.

@silentrald silentrald force-pushed the bugfix/linux-env-parser branch from af28909 to d113c09 Compare January 20, 2025 17:44
@silentrald
Copy link
Contributor Author

@Zagrios can you check if "Could not properly parse the env var string." would fine for env parsing errors, before I go translating. Also check my test cases for parseEnvString should also suffice, or we can add more to handle some error cases as well.

@silentrald silentrald force-pushed the bugfix/linux-env-parser branch from d0ea619 to c6ff848 Compare January 24, 2025 12:28
Copy link

Copy link
Owner

@Zagrios Zagrios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👌

@Zagrios
Copy link
Owner

Zagrios commented Jan 28, 2025

Thanks @silentrald ! ❤️
Merging 🎉

@Zagrios Zagrios merged commit 39afc09 into Zagrios:master Jan 28, 2025
5 checks passed
@silentrald silentrald deleted the bugfix/linux-env-parser branch January 28, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants