Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto-fix by flir #58

Closed
wants to merge 1 commit into from
Closed

auto-fix by flir #58

wants to merge 1 commit into from

Conversation

ShixiangWang
Copy link
Collaborator

I tried flir::fix_package() and found some code could be optimized.

Also there are many potential code issues cannot be fixed automatically, I knitr it to a table, you can go through to see if fixes are necessary.

issues = flir::lint_package()

library(kableExtra)
library(magrittr)


kbl(issues) %>%
  kable_paper() %>%
  save_kable(file = "flir_issues.html", self_contained = T)

flir_issues.html.zip

@Yunuuuu
Copy link
Owner

Yunuuuu commented Apr 11, 2025

rep_len cannot be used with grid::unit object

@Yunuuuu
Copy link
Owner

Yunuuuu commented Apr 11, 2025

这个包感觉不太智能

@Yunuuuu
Copy link
Owner

Yunuuuu commented Apr 11, 2025

![image](https://github.com/user-attachments/assets/63ff0777-646b-4065-ae19-a87040af6
我看了下这个文档,都是warning

@ShixiangWang
Copy link
Collaborator Author

rep_len cannot be used with grid::unit object

那就是有问题了

@Yunuuuu
Copy link
Owner

Yunuuuu commented Apr 12, 2025

我一般都是能用rep_len 就用rep_len,但是也是发现问题才没用了

@ShixiangWang
Copy link
Collaborator Author

你的代码已经写的非常好了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants