Skip to content

Missing value filter hinders advanced users access complete GSEA result #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hsiaoyi0504 opened this issue Apr 7, 2025 · 1 comment

Comments

@hsiaoyi0504
Copy link

Both GSEA method currently filter out terms with missing values in p-value column.

DOSE/R/gsea.R

Line 88 in 1ce3c6f

res <- res[!is.na(res$pvalue),]

DOSE/R/gsea.R

Line 324 in 1ce3c6f

res <- res[!is.na(res$pvalue),]

This might not be ideal since cases with unbalanced gene-level statistic values, pval, padj, NES, log2err are set to NA, which further prevent users that would like to view the complete results without any cutoffs by setting pValueCutoff=1. Could we have a separate argument like reportNA to ensure advanced users could access the results?

5: In fgseaMultilevel(pathways = pathways, stats = stats,  ... :
  There were 2 pathways for which P-values were not calculated properly due to unbalanced (positive and negative) gene-level statistic values. For such pathways pval, padj, NES, log2err are set to NA. You can try to increase the value of the argument nPermSimple (for example set it nPermSimple = 10000)
@hsiaoyi0504
Copy link
Author

Additionally, when such cases happened when by="DOSE", no any warning messages will be shown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant