From dc9d72e47e5fe44f29299d0e0a7e3d359a525060 Mon Sep 17 00:00:00 2001 From: Leo Date: Fri, 26 Jul 2024 15:35:58 +1000 Subject: [PATCH 01/10] Create Language Request Template --- .github/ISSUE_TEMPLATE/1-language.yml | 28 +++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/1-language.yml diff --git a/.github/ISSUE_TEMPLATE/1-language.yml b/.github/ISSUE_TEMPLATE/1-language.yml new file mode 100644 index 00000000..c1856094 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/1-language.yml @@ -0,0 +1,28 @@ +name: Request a New Locale +about: Request a new language for translations. +title: "(Language Name) [(Tag)]" +labels: "Language Coordination" +body: +- type: input + label: Language Name + description: "The name of the language you'd like to request." + placeholder: English + validations: + required: true +- type: input + label: IETF Language Tag + description: "The [IETF Language Tag](https://en.wikipedia.org/wiki/IETF_language_tag) for the language you're requesting." + placeholder: en + validations: + required: true +- type: checkboxes + label: Requirements + options: + - label: "I have checked that the language does not already exist in the repository." + required: true + - label: "I have checked that there are no currently open requests for this language." + required: true + - label: "I have checked that the Language Name and Locale Code are correct and both match." + required: true +# TODO: Verify this? as per README. +# - label: "I have checked that there is a Pluralizer available for my language." From ed32db5119a0ea4362fc3595f5f605b8ba64c98c Mon Sep 17 00:00:00 2001 From: Leo Date: Fri, 26 Jul 2024 15:37:48 +1000 Subject: [PATCH 02/10] fix: indentation Fix indentation issues causing template errors (why does github not let me preview templates before committing aaa) --- .github/ISSUE_TEMPLATE/1-language.yml | 42 +++++++++++++-------------- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/1-language.yml b/.github/ISSUE_TEMPLATE/1-language.yml index c1856094..b88f1a52 100644 --- a/.github/ISSUE_TEMPLATE/1-language.yml +++ b/.github/ISSUE_TEMPLATE/1-language.yml @@ -3,26 +3,26 @@ about: Request a new language for translations. title: "(Language Name) [(Tag)]" labels: "Language Coordination" body: -- type: input - label: Language Name - description: "The name of the language you'd like to request." - placeholder: English - validations: - required: true -- type: input - label: IETF Language Tag - description: "The [IETF Language Tag](https://en.wikipedia.org/wiki/IETF_language_tag) for the language you're requesting." - placeholder: en - validations: - required: true -- type: checkboxes - label: Requirements - options: - - label: "I have checked that the language does not already exist in the repository." + - type: input + label: Language Name + description: "The name of the language you'd like to request." + placeholder: English + validations: required: true - - label: "I have checked that there are no currently open requests for this language." + - type: input + label: IETF Language Tag + description: "The [IETF Language Tag](https://en.wikipedia.org/wiki/IETF_language_tag) for the language you're requesting." + placeholder: en + validations: required: true - - label: "I have checked that the Language Name and Locale Code are correct and both match." - required: true -# TODO: Verify this? as per README. -# - label: "I have checked that there is a Pluralizer available for my language." + - type: checkboxes + label: Requirements + options: + - label: "I have checked that the language does not already exist in the repository." + required: true + - label: "I have checked that there are no currently open requests for this language." + required: true + - label: "I have checked that the Language Name and Locale Code are correct and both match." + required: true + # TODO: Verify this? as per README. + # - label: "I have checked that there is a Pluralizer available for my language." From d99fa0dc898f4610c34cbc03c84fb699404178a0 Mon Sep 17 00:00:00 2001 From: Leo Date: Fri, 26 Jul 2024 15:39:27 +1000 Subject: [PATCH 03/10] fix: replace `about` with `description` This is getting mildly ridiculous. --- .github/ISSUE_TEMPLATE/1-language.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/1-language.yml b/.github/ISSUE_TEMPLATE/1-language.yml index b88f1a52..f177dbf9 100644 --- a/.github/ISSUE_TEMPLATE/1-language.yml +++ b/.github/ISSUE_TEMPLATE/1-language.yml @@ -1,5 +1,5 @@ name: Request a New Locale -about: Request a new language for translations. +description: Request a new language for translations. title: "(Language Name) [(Tag)]" labels: "Language Coordination" body: From df7bf14f4f0f1c02f2b21d1f330f1d2bf38efc2c Mon Sep 17 00:00:00 2001 From: Leo Date: Fri, 26 Jul 2024 15:41:07 +1000 Subject: [PATCH 04/10] fix: attributes Github. Why. --- .github/ISSUE_TEMPLATE/1-language.yml | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/1-language.yml b/.github/ISSUE_TEMPLATE/1-language.yml index f177dbf9..a7f5ce76 100644 --- a/.github/ISSUE_TEMPLATE/1-language.yml +++ b/.github/ISSUE_TEMPLATE/1-language.yml @@ -4,19 +4,22 @@ title: "(Language Name) [(Tag)]" labels: "Language Coordination" body: - type: input - label: Language Name - description: "The name of the language you'd like to request." - placeholder: English + attributes: + label: Language Name + description: "The name of the language you'd like to request." + placeholder: English validations: required: true - type: input - label: IETF Language Tag - description: "The [IETF Language Tag](https://en.wikipedia.org/wiki/IETF_language_tag) for the language you're requesting." - placeholder: en + attributes: + label: IETF Language Tag + description: "The [IETF Language Tag](https://en.wikipedia.org/wiki/IETF_language_tag) for the language you're requesting." + placeholder: en validations: required: true - type: checkboxes - label: Requirements + attributes: + label: Requirements options: - label: "I have checked that the language does not already exist in the repository." required: true From c503d09a7f8afc4ffbaaeedf36a3cb9ed71d30a1 Mon Sep 17 00:00:00 2001 From: Leo Date: Fri, 26 Jul 2024 15:41:37 +1000 Subject: [PATCH 05/10] fix: requirements checkboxes I give up. --- .github/ISSUE_TEMPLATE/1-language.yml | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/1-language.yml b/.github/ISSUE_TEMPLATE/1-language.yml index a7f5ce76..c3a5460d 100644 --- a/.github/ISSUE_TEMPLATE/1-language.yml +++ b/.github/ISSUE_TEMPLATE/1-language.yml @@ -20,12 +20,12 @@ body: - type: checkboxes attributes: label: Requirements - options: - - label: "I have checked that the language does not already exist in the repository." - required: true - - label: "I have checked that there are no currently open requests for this language." - required: true - - label: "I have checked that the Language Name and Locale Code are correct and both match." - required: true - # TODO: Verify this? as per README. - # - label: "I have checked that there is a Pluralizer available for my language." + options: + - label: "I have checked that the language does not already exist in the repository." + required: true + - label: "I have checked that there are no currently open requests for this language." + required: true + - label: "I have checked that the Language Name and Locale Code are correct and both match." + required: true + # TODO: Verify this? as per README. + # - label: "I have checked that there is a Pluralizer available for my language." From 73573cda812bb0f70a4a885e19337ffaf90119a4 Mon Sep 17 00:00:00 2001 From: Leo Date: Fri, 26 Jul 2024 15:59:03 +1000 Subject: [PATCH 06/10] Create Translation Issue Template --- .github/ISSUE_TEMPLATE/2-translation.yml | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/2-translation.yml diff --git a/.github/ISSUE_TEMPLATE/2-translation.yml b/.github/ISSUE_TEMPLATE/2-translation.yml new file mode 100644 index 00000000..00c69620 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/2-translation.yml @@ -0,0 +1,22 @@ +name: Translation Issue +description: Report an issue with an existing translation +body: + - type: input + attributes: + label: Affected Language + description: The name and/or tag of the language where the issue occurs + placeholder: English + validations: + required: true + - type: input + attributes: + label: Translation Key + description: The translation key(s) that are incorrectly translated + placeholder: Contacts.NoSession + validations: + required: true + - type: markdown + attributes: + label: Description + value: | + Please write a detailed explanation of the issue here. From 50b5527d762a5ec5e2ac17fb22af9239111864e8 Mon Sep 17 00:00:00 2001 From: Leo Date: Fri, 26 Jul 2024 15:59:30 +1000 Subject: [PATCH 07/10] fix: remove label from markdown field --- .github/ISSUE_TEMPLATE/2-translation.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/2-translation.yml b/.github/ISSUE_TEMPLATE/2-translation.yml index 00c69620..a5714bc3 100644 --- a/.github/ISSUE_TEMPLATE/2-translation.yml +++ b/.github/ISSUE_TEMPLATE/2-translation.yml @@ -17,6 +17,5 @@ body: required: true - type: markdown attributes: - label: Description value: | Please write a detailed explanation of the issue here. From acdaf5f3434b69d44d8c58c91c91561a3fc8a052 Mon Sep 17 00:00:00 2001 From: Leo Date: Fri, 26 Jul 2024 16:00:45 +1000 Subject: [PATCH 08/10] fix: replace markdown with textarea --- .github/ISSUE_TEMPLATE/2-translation.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/2-translation.yml b/.github/ISSUE_TEMPLATE/2-translation.yml index a5714bc3..f6674b6e 100644 --- a/.github/ISSUE_TEMPLATE/2-translation.yml +++ b/.github/ISSUE_TEMPLATE/2-translation.yml @@ -15,7 +15,7 @@ body: placeholder: Contacts.NoSession validations: required: true - - type: markdown + - type: textarea attributes: - value: | - Please write a detailed explanation of the issue here. + label: Description + description: Please write a detailed explanation of the issue here. From 2cdd03155828af3ab4c1fbcbd456a00cf8336180 Mon Sep 17 00:00:00 2001 From: Leo Date: Fri, 26 Jul 2024 16:13:13 +1000 Subject: [PATCH 09/10] Create Missing Key Template --- .github/ISSUE_TEMPLATE/3-missing.yml | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/3-missing.yml diff --git a/.github/ISSUE_TEMPLATE/3-missing.yml b/.github/ISSUE_TEMPLATE/3-missing.yml new file mode 100644 index 00000000..cbe4df3d --- /dev/null +++ b/.github/ISSUE_TEMPLATE/3-missing.yml @@ -0,0 +1,24 @@ +name: Missing Key +description: Report a translation key missing from the base locale. +labels: NewStrings +body: + - type: markdown + attributes: + value: | + This template is for keys missing from the base locale (`en`/English). + If your report is about a translation missing a language *other than* English, please consider [using a different issue template](https://github.com/Yellow-Dog-Man/Locale/issues/new/choose). + - type: input + attributes: + label: Translation Key + description: The Translation Key missing from the base locale. + placeholder: Contacts.NoSession + - type: textarea + attributes: + label: Description + description: Where did you encounter this string? What should its translation be? + - type: checkboxes + attributes: + label: Requirements + options: + - label: "This key is missing from the base locale (English)" + required: true From faf7fb5498c4eed64ac889f0f6f59165e46609f2 Mon Sep 17 00:00:00 2001 From: Leo Date: Fri, 26 Jul 2024 16:16:27 +1000 Subject: [PATCH 10/10] feat: type dropdown for translation issues --- .github/ISSUE_TEMPLATE/2-translation.yml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/.github/ISSUE_TEMPLATE/2-translation.yml b/.github/ISSUE_TEMPLATE/2-translation.yml index f6674b6e..34d3c8e4 100644 --- a/.github/ISSUE_TEMPLATE/2-translation.yml +++ b/.github/ISSUE_TEMPLATE/2-translation.yml @@ -1,6 +1,14 @@ name: Translation Issue description: Report an issue with an existing translation body: + - type: dropdown + attributes: + label: Issue Type + description: What kind of translation issue are you reporting? + options: + - Incorrect Translation + - Missing Translation + # note(LeoCatsune): Other types here? - type: input attributes: label: Affected Language