hotfix: 닉네임 변경 없이 프로필 수정시 닉네임 중복 제약에 걸리는 오류 수정

YAPP-Github · Mar 24, 2024 · 9a68493 · 9a68493
1 parent 9418bb8
commit 9a68493
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/src/main/java/com/baro/member/application/MemberService.java b/src/main/java/com/baro/member/application/MemberService.java
@@ -39,7 +39,9 @@ public GetMemberProfileResult getMyProfile(Long id) {
 
     public void updateProfile(UpdateMemberProfileCommand command) {
         Member member = memberRepository.getById(command.id());
-        validateDuplicatedNickname(command.nickname());
+        if (member.isOtherNickname(command.nickname())) {
+            validateDuplicatedNickname(command.nickname());
+        }
         member.updateProfile(command.name(), command.nickname());
     }
 

diff --git a/src/main/java/com/baro/member/domain/Member.java b/src/main/java/com/baro/member/domain/Member.java
@@ -98,4 +98,8 @@ public boolean isDefaultImage() {
     public void updateProfileImage(String profileImageUrl) {
         this.profileImageUrl = profileImageUrl;
     }
+
+    public boolean isOtherNickname(String nickname) {
+        return !this.nickname.value().equals(nickname);
+    }
 }
diff --git a/src/test/java/com/baro/member/application/MemberServiceTest.java b/src/test/java/com/baro/member/application/MemberServiceTest.java
@@ -90,7 +90,8 @@ void setUp() {
     @Test
     void 사용자_프로필_수정_닉네임_중복_예외_발생() {
         // given
-        Member savedMember = memberRepository.save(MemberFixture.memberWithNickname("바로닉네임"));
+        memberRepository.save(MemberFixture.memberWithNickname("바로닉네임"));
+        Member savedMember = memberRepository.save(MemberFixture.memberWithNickname("이전닉네임"));
         UpdateMemberProfileCommand command = new UpdateMemberProfileCommand(
                 savedMember.getId(),
                 "바로",