[LINKER-X] fix: Pagination 공통화, 연락처 관심사 기반 뉴스 가져오기 #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktj1997
commented
Feb 18, 2024
Comment on lines
+123
to
+139
| @GetMapping("/{contactId}/interest/news") | ||
| @Operation(summary = "연락처 관심사 기반 뉴스 가져오기") | ||
| public ApiResponse<GetContactInterestNewsResponse.Recommendations> getContactInterestRelatedNews( | ||
| @PathVariable Long contactId, | ||
| @RequestParam(defaultValue = "20") int size, | ||
| @AuthenticatedUserContext AuthenticatedUserContextHolder userContextHolder) { | ||
| List<TagSpecificNews> tagSpecificNewsList = | ||
| searchService.searchContactInterestRelatedNews(contactId, userContextHolder.getId(), size); | ||
|
|
||
| GetContactInterestNewsResponse.Recommendations recommendations = | ||
| new GetContactInterestNewsResponse.Recommendations( | ||
| tagSpecificNewsList.stream() | ||
| .map(GetContactInterestNewsResponse.Recommendation::fromTagSpecificNews) | ||
| .toList()); | ||
| return ApiResponse.success(recommendations); | ||
| } | ||
|
|
There was a problem hiding this comment.
연락처 상세 -> 관심주제 부분 API 구성완료하였습니다.
프론트쪽 공수가 더 많이 들 것 같아 우선 구성하였습니다
Comment on lines
+19
to
+26
| public class ContactSearchService { | ||
|
|
||
| private final NewsReader newsReader; | ||
| private final ContactsReader contactsReader; | ||
| private final ContactInterestReader contactInterestReader; | ||
| private final ContactsBookmarkReader contactsBookmarkReader; | ||
| private final ScheduleParticipantReader scheduleParticipantReader; | ||
| private final TagSpecificNewsListFactory tagSpecificNewsListFactory; |
There was a problem hiding this comment.
기존 ContactsService가 비대해지는 것 같아 Service분리하였습니다
| @@ -16,34 +11,8 @@ | |||
| public class ContactsService { | |||
Comment on lines
+23
to
26
| NewsPaginationQueryCondition condition = | ||
| new NewsPaginationQueryCondition(size, tagIds, cursorId); | ||
| return newsRepository.findAllByTagIdWithCursor(condition); | ||
| } |
There was a problem hiding this comment.
기존 코드 삭제 했던 부분 다시 롤백시켰습니다
Comment on lines
+14
to
+19
| public class TagSpecificNewsListFactory { | ||
|
|
||
| private final TagReader tagReader; | ||
|
|
||
| public List<TagSpecificNews> build( | ||
| List<Long> tagIds, CursorPaginationResult<News> selectedTagsNewsList) { |
There was a problem hiding this comment.
공통적으로 많이 사용할 것 같아 Factory로 분리하였습니다
Comment on lines
6
to
12
| public class CursorPaginationTemplate { | ||
| public static <T extends CursorExtractable> CursorPaginationResult<T> execute( | ||
| int size, Function<Integer, List<T>> query) { | ||
| List<T> data = query.apply(size + 1); | ||
| Long cursor, int size, BiFunction<Long, Integer, List<T>> query) { | ||
| List<T> data = query.apply(cursor, size + 1); | ||
| boolean hasNext = data.size() == size + 1; | ||
| Long nextCursor = hasNext ? data.get(size).getId() : null; | ||
|
|
There was a problem hiding this comment.
커서기반 페이지네이션 공통모듈입니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📍 작업 배경 #
📝 작업 내용 #
💬 코멘트 #