Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LINKER-X] Cralwer모듈 추가 #26

Merged
merged 1 commit into from
Jan 21, 2024
Merged

[LINKER-X] Cralwer모듈 추가 #26

merged 1 commit into from
Jan 21, 2024

Conversation

ktj1997
Copy link
Contributor

@ktj1997 ktj1997 commented Jan 21, 2024

📍 작업 배경 #

  • issue : #

📝 작업 내용 #

  • Crawler 모듈을 추가하였습니다.
  • api를 별도의 서버로 띄울 필요는없기 떄문에, core-api모듈에 같이 올릴 생각입니다.
    • api와 Cralwer의 역할이 다르기 떄문에, 모듈분리는진행하였습니다.
  • Crawler모듈에는 수행할 api와, Crawler관련 설정 및 Service를 정의하고 Domain에서는 단순하게 News저장을 수행하는것을 생각했습니다

💬 코멘트 #

ktj1997
ktj1997 commented Jan 21, 2024
View reviewed changes
crawler/src/main/java/com/imlinker/crawler/CrawlerController.java
import org.springframework.web.bind.annotation.RestController;

@RestController
@RequestMapping("/api/v1/crawler")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

endpoint에 api를뺴야하나 고민이긴하네요 ㅋㅋ

@ktj1997 ktj1997 merged commit bb0e093 into dev Jan 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ktj1997