Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docker] Derive FINN_DOCKER_TAG from the SCRIPTPATH #1182

Merged
merged 3 commits into from
Feb 20, 2025

Conversation

iksnagreb
Copy link
Contributor

Previously the FINN_DOCKER_TAG has been derived by "git describe" in the current working directory, which fails if this is not the base of the FINN repository. As we know the SCRIPTPATH, which always resides in the base of the FINN repository, we can nagivate there, derive the docker tag and navigate back to the working directory.

Previously the FINN_DOCKER_TAG has been derived by "git describe" in the
current working directory, which fails if this is not the base of the
FINN repository. As we know the SCRIPTPATH, which always resides in the
base of the FINN repository, we can nagivate there, derive the docker
tag and navigate back to the working directory.
@auphelia
Copy link
Collaborator

Thanks @iksnagreb !

@auphelia auphelia merged commit e486c03 into Xilinx:dev Feb 20, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants