From 4788ebe5453ea63541f98930627f9a3c3e53eca6 Mon Sep 17 00:00:00 2001 From: Shane Fleming Date: Wed, 26 Feb 2025 12:02:07 +0000 Subject: [PATCH] Updated the tests to check for a fifo size that was previously splitting with a fifo depth of 1, added an assertion to check all fifo depths are okay --- src/finn/transformation/fpgadataflow/set_fifo_depths.py | 2 +- tests/fpgadataflow/test_split_large_fifos.py | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/finn/transformation/fpgadataflow/set_fifo_depths.py b/src/finn/transformation/fpgadataflow/set_fifo_depths.py index e4117e45f5..c3baf80aab 100644 --- a/src/finn/transformation/fpgadataflow/set_fifo_depths.py +++ b/src/finn/transformation/fpgadataflow/set_fifo_depths.py @@ -539,7 +539,7 @@ def decompose_pow2(x): ret_final = [] for cand_depth in ret_pass2: if cand_depth <= max_qsrl_depth: - ret_final.append((max(2,cand_depth), "rtl")) + ret_final.append((max(2, cand_depth), "rtl")) else: ret_final.append((cand_depth, "vivado")) diff --git a/tests/fpgadataflow/test_split_large_fifos.py b/tests/fpgadataflow/test_split_large_fifos.py index d192755d06..c9db73b36d 100644 --- a/tests/fpgadataflow/test_split_large_fifos.py +++ b/tests/fpgadataflow/test_split_large_fifos.py @@ -63,7 +63,7 @@ def get_folding_cfg(depth=65536): @pytest.mark.slow @pytest.mark.vivado @pytest.mark.fpgadataflow -@pytest.mark.parametrize("depth", [16384, 65536, 45000]) +@pytest.mark.parametrize("depth", [16384, 65536, 45000, 1537]) @pytest.mark.parametrize("force_python_rtlsim", ["True", "False"]) def test_split_large_fifos(depth, force_python_rtlsim): tmp_output_dir = fetch_test_model("tfc") @@ -103,6 +103,7 @@ def test_split_large_fifos(depth, force_python_rtlsim): inst = getCustomOp(fifo_node) fifo_depth = inst.get_nodeattr("depth") assert fifo_depth == golden_cfg[i % len(golden_cfg)][0] + assert fifo_depth > 1 shutil.rmtree(tmp_output_dir)