Store 'raw' md5sum value in note.xrt.uid #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stsoe
reviewed
Feb 27, 2025
| @@ -183,38 +183,38 @@ add_text_data_section(std::vector<writer>& mwriter, std::vector<symbol>& syms) | |||
| { | |||
| for(auto buffer : mwriter) | |||
There was a problem hiding this comment.
This is a lot of copying, should it be auto&
There was a problem hiding this comment.
We have the copy inefficiency in several places. Will consider cleaning this up in a separate PR.
…ation Signed-off-by: Sonal Santan <sonal.santan@amd.com>
Signed-off-by: Sonal Santan <sonal.santan@amd.com>
Signed-off-by: Sonal Santan <sonal.santan@amd.com>
Signed-off-by: Sonal Santan <sonal.santan@amd.com>
Signed-off-by: Sonal Santan <sonal.santan@amd.com>
stsoe
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
Currently we are generating md5sum, converting it to ASCII hex and then storing the hex string as raw value in note.xrt.uid. Hence the value stored is binary representation of the hex string is not the original md5sum which is wrong.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
The issue has been there from the beginning
How problem was solved, alternative solutions (if any) and why they were rejected
Fixed by updating the md5sum generation and string representation in aiebu::uid_md5 class.
Risks (if any) associated the changes in the commit
None
What has been tested and how, request additional testing if necessary
Build and ctest validated
Documentation impact (if any)
NA