Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: remove Buffer polyfill for react-native #2595

Merged
merged 1 commit into from
Dec 4, 2023
Merged

docs: remove Buffer polyfill for react-native #2595

merged 1 commit into from
Dec 4, 2023

Conversation

ckniffen
Copy link
Collaborator

@ckniffen ckniffen commented Dec 4, 2023

High Level Overview of Change

React native no longer needs a polyfill after xrpl@3.0.0-beta.1

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates

Did you update HISTORY.md?

  • Yes
  • No, this change does not impact library users

@ckniffen
docs: remove Buffer polyfill for react-native
d0c6c64 
React native no longer needs a polyfill after `xrpl@3.0.0-beta.1`
@ckniffen ckniffen added the 3.0 label Dec 4, 2023
JST5000
JST5000 approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@JST5000 JST5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ckniffen ckniffen merged commit dc6355f into 3.0 Dec 4, 2023
@ckniffen ckniffen deleted the feature/remove-polyfill-for-native branch December 4, 2023 21:28
ckniffen added a commit that referenced this pull request Feb 1, 2024
@ckniffen
docs: remove Buffer polyfill for react-native (#2595)
e9b80e7 
React native no longer needs a polyfill after `xrpl@3.0.0-beta.1`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinr1234 justinr1234 justinr1234 approved these changes

@JST5000 JST5000 JST5000 approved these changes

@khancode khancode Awaiting requested review from khancode

Assignees
No one assigned
Labels
3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ckniffen @justinr1234 @JST5000