Brand kit updates #2269
Brand kit updates #2269
Conversation
…it deletes old one replaces all references to new url
…it deletes old one replaces all references to new url
|
Link check report. 554142 links checked. Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/brand-kit/ |
There was a problem hiding this comment.
The local build looked good.
Wondering if the zip files should be under assets instead of the content folder? @mDuo13 what do you think?
I put it in content as that is where it was being hosted before. |
content/XRPL_Brand_Kit.zip
Outdated
There was a problem hiding this comment.
I don't love that this zip has a __MACOSX/ folder at the top and .DS_Store files in every dir, but it's fine I guess.
There was a problem hiding this comment.
While not a blocker, I'd prefer that we remove these files as they sometimes can cause problems.
There was a problem hiding this comment.
It's OK for the brand kit to be in content/ because we're linking people to download it from GitHub via the github.com/.../raw/... link. However, if we moved it under assets/, then we could serve it directly from xrpl.org at a URL like https://xrpl.org/assets/XRPL_Brand_Kit.zip, which might make it easier to track how many times it's been downloaded (using the server access log or something).
Co-authored-by: tequ <git@tequ.dev>
|
Link check report. 554142 links checked. Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/brand-kit/ |
Moved into assets |
|
Link check report. 554144 links checked. Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/brand-kit/ |
No description provided.