Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow silencing 'Thread not found' errors #214

Open
MitchPetersen opened this issue Dec 29, 2024 · 2 comments
Open

Allow silencing 'Thread not found' errors #214

MitchPetersen opened this issue Dec 29, 2024 · 2 comments
Assignees
Labels
bugfix Something isn't working

Comments

@MitchPetersen
Copy link

MitchPetersen commented Dec 29, 2024

Issue

A thread has been sitting in F95Checker awaiting an eventual (hopefully) update from the dev. Consider it imported properly, installed, played, stagnant in the UI.

Yesterday at some point, either a change in the thread, or a change in the API was made, and it seems that the API has misplaced this entry.

The thread is not archived, and still exists.

Reproducible steps

  • Add thread 184252 to F95 Checker
  • Try and pull thread details

API output

/184252?ts=1735450781

{"INDEX_ERROR":"THREAD_MISSING"}

/fast?ids=184252

{"184252":1735450781}

Suggested Remedy

It would be nice to avoid having a popup stating that the thread has been removed every subsequent time thread updates are requested.

In cases like this, I don't want to do anything with this game entry, and I'd prefer to just wait for it to re-appear in the API endpoint.

Potentially add a new status for games, Unknown or Removed? or Missing? And do a status change for the game instead, possibly with a tool tip explanation of the meaning, and suggested remedies that are explained in the current pop-up.

@MitchPetersen MitchPetersen changed the title Issue with API /full pull. Issue with API endpoint /full Dec 29, 2024
@Willy-JL
Copy link
Owner

This was discussed in detail on the f95zone thread. It will be mitigated by letting the 12-hour version check and the 5-minute latest updates check detect if a thread cached as non existent actually exists, aswell as allowing the end user to ignore this error for a certain amount of time or indefinitely.

@Willy-JL Willy-JL added the bugfix Something isn't working label Dec 30, 2024
@Willy-JL Willy-JL moved this to In Progress in F95Checker Dec 30, 2024
@Willy-JL Willy-JL self-assigned this Dec 30, 2024
@Willy-JL
Copy link
Owner

after looking into the issue, it turns out it was likely due to a ddos-guard 403 response being wrongly interpreted as the thread missing, this is fixed by #215 .

Potentially add a new status for games, Unknown or Removed? or Missing? And do a status change for the game instead, possibly with a tool tip explanation of the meaning, and suggested remedies that are explained in the current pop-up.

for games that have actually been removed, i think a popup is still necessary so the user actually notices, a simple icon would go unnoticed. however i agree that there should be a way to silence the error once it has been acknowledged the first time, such as

allowing the end user to ignore this error for a certain amount of time or indefinitely.

@Willy-JL Willy-JL changed the title Issue with API endpoint /full Allow silencing 'Thread not found' errors Jan 11, 2025
@Willy-JL Willy-JL moved this from In Progress to To Do in F95Checker Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Something isn't working
Projects
Status: To Do
Development

No branches or pull requests

2 participants