Feature/xpt2046 #916
Feature/xpt2046 #916
Conversation
| public int X { get; set; } | ||
| public int Y { get; set; } | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Represents a circle in the user interface. | ||
| /// </summary> | ||
| public class Circle : ThemedControl | ||
| { | ||
| private Color _foreColor; |
There was a problem hiding this comment.
you heard the boss - underscores need to go
| @@ -7,12 +7,6 @@ | |||
| <Nullable>enable</Nullable> | |||
| </PropertyGroup> | |||
|
|
|||
| <ItemGroup> | |||
There was a problem hiding this comment.
I assume this is intentional?
There was a problem hiding this comment.
Yes. libmpsse.dll is no longer required for FT232, so it's just removing library cruft
Source/Meadow.Foundation.Peripherals/Sensors.Hid.Xpt2046/Driver/Sensors.Hid.Xpt2046.csproj
Outdated
Show resolved
Hide resolved
...and_Frameworks/Graphics.MicroLayout/Samples/Ili9488Charts_Sample/Ili9488Charts_Sample.csproj
Show resolved
Hide resolved
| public int X { get; set; } | ||
| public int Y { get; set; } | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Represents a circle in the user interface. | ||
| /// </summary> | ||
| public class Circle : ThemedControl |
There was a problem hiding this comment.
I'm wondering now if circle makes sense as a control ... we should talk about how we should handle drawing primitives
There was a problem hiding this comment.
I would have preferred an Elipse, but we don't have the ability to draw that. It matches with the Box control. But yes, we can definitely discuss.
There was a problem hiding this comment.
nothing to block on of course
...ce/Meadow.Foundation.Libraries_and_Frameworks/Graphics.MicroLayout/Driver/Controls/Circle.cs
Outdated
Show resolved
Hide resolved
Source/Meadow.Foundation.Peripherals/Sensors.Hid.Xpt2046/Samples/Tsc2004_Sample/MeadowApp.cs
Outdated
Show resolved
Hide resolved
Source/Meadow.Foundation.Peripherals/Sensors.Hid.Xpt2046/Driver/Sensors.Hid.Xpt2046.csproj
Outdated
Show resolved
Hide resolved
Source/Meadow.Foundation.Peripherals/Sensors.Hid.Xpt2046/Driver/Sensors.Hid.Xpt2046.csproj
Outdated
Show resolved
Hide resolved
...adow.Foundation.Peripherals/Sensors.Hid.Xpt2046/Samples/Tsc2004_Sample/Tsc2004_Sample.csproj
Outdated
Show resolved
Hide resolved
Source/Meadow.Foundation.Peripherals/Sensors.Hid.Xpt2046/Driver/Sensors.Hid.Xpt2046.csproj
Show resolved
Hide resolved
| public int X { get; set; } | ||
| public int Y { get; set; } | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Represents a circle in the user interface. | ||
| /// </summary> | ||
| public class Circle : ThemedControl |
There was a problem hiding this comment.
nothing to block on of course
No description provided.