Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace custom search endpoint with WP 5.0 search endpoint #8

Open
mharis opened this issue Dec 7, 2018 · 1 comment
Open

Replace custom search endpoint with WP 5.0 search endpoint #8

mharis opened this issue Dec 7, 2018 · 1 comment
Labels
enhancement New feature or request question Further information is requested

Comments

@mharis
Copy link
Contributor

mharis commented Dec 7, 2018

I have not explored the new search endpoint that comes with WordPress 5.0 but we can probably replace our custom endpoint with the core search endpoint.

https://make.wordpress.org/core/2018/12/06/the-rest-api-in-wordpress-5-0/
@mharis mharis added enhancement New feature or request question Further information is requested labels Dec 7, 2018
@davebonds
Copy link
Contributor

I definitely think we should explore replacing this with the core endpoint due to weirdness with our custom endpoint when no results are found.

@coreymcollins coreymcollins mentioned this issue Dec 9, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davebonds @mharis