-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable variable session time for mpcCoreKit #89
Conversation
This PR is depended on the torus.js PR, torusresearch/torus.js#129 To make this
Will update the PR again once this, torusresearch/torus.js#129, is merged and published |
Updated However, to make this variable session time works properly, we still need the following things
Currently, I've used
|
src/mpcCoreKit.ts
Outdated
@@ -116,6 +116,7 @@ export class Web3AuthMPCCoreKit implements ICoreKit { | |||
if (typeof options.manualSync !== "boolean") options.manualSync = false; | |||
if (!options.web3AuthNetwork) options.web3AuthNetwork = WEB3AUTH_NETWORK.MAINNET; | |||
if (!options.sessionTime) options.sessionTime = 86400; | |||
if (!options.serverTimeOffset) options.serverTimeOffset = 0; // ms |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to pass this param in torus.js and customAuth constructor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made a PR, torusresearch/CustomAuth#331 to include serverTimeOffset
value in respective constructors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay, till we merge and release custom auth, can you remove serverTimeOffset param from this sdk
custom session time
for SessionToken Data based on the clients' subscribe planssession time