Skip to content
This repository was archived by the owner on Oct 23, 2023. It is now read-only.

Tracey thomas practice #7

Draft
wants to merge 9 commits into
base: intern-practice
Choose a base branch
from

Conversation

traceythomasww
Copy link

Draft with analysis.

Copy link

@znorcross211 znorcross211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall great job! The concepts you worked on here will hopefully help you venturing into the wider CMX org.

Comment on lines +23 to +28
parseIt.mockImplementation(() => {
return {
getDate: getDateMock,
getAllDates: getAllDatesMock.mockReturnValue(dateFixtures)
}
})

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we discussed this but this could get extracted using the method described at the top of the docs here. Not vital for this but it is often used.
https://jestjs.io/docs/manual-mocks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants