Better driver controls #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex-Dog
approved these changes
Mar 2, 2024
nstringham
requested changes
Mar 2, 2024
| @@ -60,4 +62,5 @@ public class Constants { | |||
| /* ROTATION PID CONSTANTS */ | |||
|
|
|||
| public static final double ROTATION_ERROR_DEGREES = 5.; | |||
| public static final double SHOOTING_VELOCITY = 4000; | |||
There was a problem hiding this comment.
What is the unit on this number?
| import frc.robot.auton.AutonShoot; | ||
| import frc.robot.auton.ExtendArms; | ||
| import frc.robot.auton.RetractArms; | ||
| import frc.robot.RobotComponents.Climber; |
There was a problem hiding this comment.
folders should have lowercase names
| public class DriveTrain { | ||
|
|
||
| public static void driveTank(double leftY, double rightY) { | ||
| QuickActions.stopDriveMotors(); |
There was a problem hiding this comment.
Why are we always stopping the motors?
| @@ -64,6 +64,6 @@ public void initiate() { | |||
|
|
|||
| @Override | |||
| public void shutdown() { | |||
| QuickActions.stopAll(); | |||
| QuickActions.stopDriveMotors(); | |||
| } | ||
| return false; | ||
|
|
||
| return Timer.getFPGATimestamp() >= revFinishedTime + 1.0; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes in this PR and why they are needed.
Checklist before marking this PR as ready for review
Once you have the PR ready for review, request reviewers from the upper-right of the screen with the cog on the reviewers section.