Make climb use encoders #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o more-auton-improvements
…o more-auton-improvements
team6101
commented
Feb 28, 2024
| extendArms(); | ||
| //extendArms(); | ||
| Robot.motors.getLeftClimb().set(Constants.CLIMB_EXTENSION_SPEED); | ||
| Robot.motors.getRightClimb().set(Constants.CLIMB_EXTENSION_SPEED); |
There was a problem hiding this comment.
we added the code to use an encoder, but there isn't an encoder, so we made the climb manual until we add an encoder
Nanosplitter
approved these changes
Feb 28, 2024
| @@ -13,12 +14,28 @@ public void addActionToRun(AutonAction action) { | |||
| } | |||
|
|
|||
| public void onEveryFrame() { | |||
| for (int i = 0; i < actions.size(); i++) { | |||
| AutonAction action = actions.get(i); | |||
| Iterator<AutonAction> it = actions.iterator(); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We made the arms use encoder positions because using time is unreliable and inconvenient
Checklist before marking this PR as ready for review
Once you have the PR ready for review, request reviewers from the upper-right of the screen with the cog on the reviewers section.