Start drive train code #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Julian Sprague <julspr@users.noreply.github.com> Co-authored-by: Dogloverblue <Dogloverblue@users.noreply.github.com> Co-authored-by: nguyenjerry2608@gmail.com <nguyenjerry2608@gmail.com> Co-authored-by: 222mi.ash@gmail.com <222mi.ash@gmail.com> Co-authored-by: atsuke-axolotl <atsuke-axolotl@users.noreply.github.com> Co-authored-by: Patricia-R <Patricia-R@users.noreply.github.com>
team6101
commented
Jan 24, 2024
Comment on lines
+102
to
+106
| driveLeftParent.set(leftY); | ||
| driveRightParent.set(rightY); | ||
|
|
||
| driveLeftChild.set(leftY); | ||
| driveRightChild.set(rightY); |
There was a problem hiding this comment.
This will be changed to a leader-follower system later. (We did not teach the new people about it yet.)
Comment on lines
+21
to
+24
| Spark driveLeftParent = new Spark(Constants.DRIVE_LEFT_PARENT_ID); | ||
| Spark driveLeftChild = new Spark(Constants.DRIVE_LEFT_CHILD_ID); | ||
| Spark driveRightParent = new Spark(Constants.DRIVE_RIGHT_PARENT_ID); | ||
| Spark driveRightChild = new Spark(Constants.DRIVE_RIGHT_CHILD_ID); |
There was a problem hiding this comment.
We don't know which type of motor controller we will be using yet, so Sparks are placeholders for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.