Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from Leaflet to ArcGIS API for JavaScript #66

Closed
JeffJacobson opened this issue Feb 15, 2023 · 0 comments · Fixed by #123
Closed

Migrate from Leaflet to ArcGIS API for JavaScript #66

JeffJacobson opened this issue Feb 15, 2023 · 0 comments · Fixed by #123
Assignees
@JeffJacobson
Labels
dependencies Pull requests that update a dependency file
Milestone
Iniital public re...

Comments

@JeffJacobson
Copy link
Contributor

JeffJacobson commented Feb 15, 2023 •
edited
Loading

Because Esri Leaflet is not as well documented and is on "maintenance" (not updated frequently), it seems like it will take less effort to switch to the ArcGIS API for JavaScript than it will be to implement remaining features with esri-leaflet and its related plugins, such as the Search control and using our own custom basemap.

  • The esri-leaflet code is full of now unnecessary polyfills for features that all modern browsers support, such as the Fetch API.
  • esri-leaflet and its plugins do not include TypeScript type definitions. The ones on Definitely Typed are out of date and do not support JavaScript Modules.
@JeffJacobson JeffJacobson added this to the Iniital public release milestone Feb 15, 2023
@JeffJacobson JeffJacobson self-assigned this Feb 15, 2023
@JeffJacobson JeffJacobson moved this to 🏗 In progress in Milepost Map Feb 15, 2023
@JeffJacobson JeffJacobson added the dependencies Pull requests that update a dependency file label Feb 16, 2023
@JeffJacobson JeffJacobson linked a pull request Jun 27, 2023 that will close this issue
Migrate to arcgis api #123
Merged
@JeffJacobson JeffJacobson pinned this issue Jul 10, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Milepost Map Jul 18, 2023
@JeffJacobson JeffJacobson unpinned this issue Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JeffJacobson JeffJacobson

Labels
dependencies Pull requests that update a dependency file
Projects
Milepost Map
Status: ✅ Done
Milestone
Iniital public release
Development

Successfully merging a pull request may close this issue.

Migrate to arcgis api WSDOT-GIS/wsdot-mp-map
1 participant
@JeffJacobson