MAGETWO-92929: Declarative schema tests are located in inappropriate

- fix test

Author: cpartica

lib/internal/Magento/Framework/Setup/Test/Unit/SchemaListenerTest.php

@@ -3,6 +3,7 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
 
 namespace Magento\Framework\Setup\Test\Unit;
 
@@ -30,7 +31,7 @@ class SchemaListenerTest extends \PHPUnit\Framework\TestCase
      */
     private $objectManagerHelper;
 
-    protected function setUp()
+    protected function setUp() : void
     {
         $this->objectManagerHelper = new ObjectManagerHelper($this);
         $this->model = $this->objectManagerHelper->getObject(
@@ -51,7 +52,7 @@ protected function setUp()
     /**
      * @return Table
      */
-    private function getCreateTableDDL($tableName)
+    private function getCreateTableDDL($tableName) : Table
     {
         $table = new Table();
         $table->setName($tableName);
@@ -91,7 +92,7 @@ private function getCreateTableDDL($tableName)
         );
     }
 
-    public function testRenameTable()
+    public function testRenameTable() : void
     {
         $this->model->setModuleName('First_Module');
         $this->model->createTable($this->getCreateTableDDL('old_table'));
@@ -101,15 +102,15 @@ public function testRenameTable()
         self::assertArrayNotHasKey('old_table', $tables['First_Module']);
     }
 
-    public function testDropIndex()
+    public function testDropIndex() : void
     {
         $this->model->setModuleName('First_Module');
         $this->model->createTable($this->getCreateTableDDL('index_table'));
         $this->model->dropIndex('index_table', 'INDEX_KEY', 'index');
         self::assertTrue($this->model->getTables()['First_Module']['index_table']['indexes']['INDEX_KEY']['disabled']);
     }
 
-    public function testCreateTable()
+    public function testCreateTable() : void
     {
         $this->model->setModuleName('First_Module');
         $this->model->createTable($this->getCreateTableDDL('new_table'));
@@ -201,7 +202,7 @@ public function testCreateTable()
         );
     }
 
-    public function testDropTable()
+    public function testDropTable() : void
     {
         $this->model->setModuleName('Old_Module');
         $this->model->createTable($this->getCreateTableDDL('old_table'));
@@ -210,7 +211,7 @@ public function testDropTable()
         self::assertTrue($this->model->getTables()['New_Module']['old_table']['disabled']);
     }
 
-    public function testDropTableInSameModule()
+    public function testDropTableInSameModule() : void
     {
         $this->model->setModuleName('Old_Module');
         $this->model->createTable($this->getCreateTableDDL('old_table'));

lib/internal/Magento/Framework/Setup/Test/Unit/SchemaPersistorTest.php

@@ -3,6 +3,7 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
 
 namespace Magento\Framework\Setup\Test\Unit;
 
@@ -38,7 +39,7 @@ class SchemaPersistorTest extends \PHPUnit\Framework\TestCase
      */
     private $xmlPersistor;
 
-    protected function setUp()
+    protected function setUp() : void
     {
         $this->componentRegistrarMock = $this->getMockBuilder(ComponentRegistrar::class)
             ->disableOriginalConstructor()
@@ -60,7 +61,7 @@ protected function setUp()
      * @param array $tables
      * @param string $expectedXML
      */
-    public function testPersist(array $tables, $expectedXML)
+    public function testPersist(array $tables, $expectedXML) : void
     {
         $moduleName = 'First_Module';
         /** @var SchemaListener|\PHPUnit_Framework_MockObject_MockObject $schemaListenerMock */
@@ -88,7 +89,7 @@ public function testPersist(array $tables, $expectedXML)
      *
      * @return array
      */
-    public function schemaListenerTablesDataProvider()
+    public function schemaListenerTablesDataProvider() : array
     {
         return [
             [