Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 148 Updates to PowerShell Scripts #149

Conversation

lmalenfant
Copy link
Member

Updated the PowerShell scripts so they can all run independently, added a script for just the VTS libraries

@lmalenfant lmalenfant requested a review from hayakawa16 May 24, 2024 16:24
@lmalenfant lmalenfant linked an issue May 24, 2024 that may be closed by this pull request
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Member

@hayakawa16 hayakawa16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran BuildTestRelease on Windows and BuildTestReleaseMCCL on Linux. Looks good. There is still a bit of an issue when running BuildTestReleaseMCCL on Linux. It controls my entire computer (no mouse control), chrome crashed. I let it be and it finished okay. Not sure what the problem is.

@lmalenfant
Copy link
Member Author

Is this new behavior or did it happen with the previous version? When you say it crashes Chrome, is that the browser that crashes?

@hayakawa16
Copy link
Member

It happened on previous version so not caused by your updates. It crashed my browser chrome. It runs fine when I run it remotely on a computer on campus because nothing else is running on that computer. I don't think it should hold up merge. I just wanted to mention it in case you saw anything that might be causing it.

@lmalenfant lmalenfant merged commit 0bca741 into master May 30, 2024
2 checks passed
@lmalenfant lmalenfant deleted the feature/148-updates-to-powershell-scripts-for-building-zip-files branch May 30, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updates to PowerShell scripts for building zip files
2 participants