Remplacer @villedemontreal/lint-config par ESLint. Fix Vulnerabilities #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current version has 3 vulnerabilities because of @villedemontreal/lint-config Replaced @villedemontreal/lint-config with eslint, code based on https://github.com/VilledeMontreal/node-logger after changes : npm audit : found 0 vulnerabilities Signed-off-by: Ricardo Machado <info@rmachado.com>
"version": "5.17.3" -> 5.17.3 ESlint rules added for code compatibility Signed-off-by: Ricardo Machado <info@rmachado.com>
Signed-off-by: Ricardo Machado <info@rmachado.com>
|
Le build fails. Les modifications me semblent bonnes de mon coté. @livetocode est-ce qu'on veut absolument garder @villedemontreal/lint-config ? Est-on mieux d'attendre la mise à jour de @villedemontreal/lint-config vers eslint ? |
OlivierAlbertini
added
the
dependencies
|
Le build fail à cause que je n'ai pas commit les modifications faites par lint-fix. |
Avec les fix de lint-fix Signed-off-by: Ricardo Machado <info@rmachado.com>
|
C'est bon pour moi. C'est correct de ne plus utiliser lint-config car on l'a éliminé du gabarit d'API pour prendre ESLint vanille. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current version has 3 vulnerabilities because of @villedemontreal/lint-config
Replaced @villedemontreal/lint-config with eslint, code based on https://github.com/VilledeMontreal/node-logger
after changes : npm audit : found 0 vulnerabilities
Signed-off-by: Ricardo Machado info@rmachado.com