Fix values rendering for Markdown engines with strict XML parsing #1869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mindw
commented
Dec 16, 2024
mindw
commented
- replace PWD with REPODIR in Makefile to fix run on PyCharm remote WSL2
* replace PWD with REPODIR in Makefile to fix run on PyCharm remote WSL2 Signed-off-by: Gabi Davar <grizzly.nyo@gmail.com>
mindw
requested review from
AndrewChubatiuk,
zekker6,
Haleygo and
f41gh7
as code owners
github-actions
bot
added
k8s-stack
| @@ -7,7 +7,7 @@ | |||
| {{- $notationType = "plaintext" }} | |||
| {{- end -}} | |||
| {{- end -}} | |||
| <pre class="helm-vars-default-value" language-yaml" lang="{{ $notationType }}"> | |||
There was a problem hiding this comment.
please revert this change everywhere as we're relying on this class in docs website
There was a problem hiding this comment.
@AndrewChubatiuk , Would class="language-yaml" do instead? what it now isn't a legal XML ...
There was a problem hiding this comment.
thanks for finding a typo, but we're using helm-vars-default-value class, which is required to render values correctly
There was a problem hiding this comment.
My apologies - I wanted to suggest helm-vars-default-value - had a brain meltdown :( .
Also, My CSS /XHTML is extremely rusty hence missing options that there was an extra " .
AndrewChubatiuk
added a commit
that referenced
this pull request
Dec 16, 2024
AndrewChubatiuk
force-pushed
the
master
branch
from
330834e to
ec141b8
Compare
AndrewChubatiuk
merged commit c486483
into
VictoriaMetrics:master
33 of 36 checks passed
|
@mindw Thanks for contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.