Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k8s-stack: allow manage default dashboards independently #1852

Merged
merged 1 commit into from
Dec 4, 2024
Merged

k8s-stack: allow manage default dashboards independently #1852

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/victoria-metrics-k8s-stack/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
## Next release

- TODO
- Set higher priority for `defaultDashboards.dashboards.<name>.enabled` flag comparing to default dashboard conditions to allow install or ignore dashboards regardless of whether component it's for is installed or monitored. See [this issue](https://github.com/VictoriaMetrics/helm-charts/issues/1851).

## 0.30.2

Expand Down
5 changes: 4 additions & 1 deletion charts/victoria-metrics-k8s-stack/templates/grafana/dashboard.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,10 @@ Get dashboard data from file
{{- /*
Save condition for a dashboard from file
*/}}
{{- $dashboardCondition := or $dashboardData.condition (dig $dashboardName "enabled" false $.Values.defaultDashboards.dashboards) -}}
{{- $dashboardCondition := $dashboardData.condition }}
{{- if hasKey (index ((($.Values).defaultDashboards).dashboards) $dashboardName) "enabled" }}
{{- $dashboardCondition = index $.Values.defaultDashboards.dashboards $dashboardName "enabled" }}
{{- end }}

{{- /*
Delete condition from dashboard
Expand Down
Loading