Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator: configurable webhook port #1507

Merged
merged 3 commits into from
Sep 19, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion charts/victoria-metrics-operator/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@

## Next release

- TODO
- Made webhook port configurable. See [this issue](https://github.com/VictoriaMetrics/helm-charts/issues/1506)
- Changed crd cleanup hook delete policy to prevent `resource already exists` error.

## 0.34.8

Expand Down
6 changes: 3 additions & 3 deletions charts/victoria-metrics-operator/Chart.lock
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
dependencies:
- name: victoria-metrics-common
repository: https://victoriametrics.github.io/helm-charts
version: 0.0.9
digest: sha256:dd59b050d7d15c0fc50f7910f64b45a744bcfc155f2414a8ae300addad5cdbc5
generated: "2024-09-03T11:58:40.092985+03:00"
version: 0.0.13
digest: sha256:6d82d9a15a778259efa73e4798f46d461877cea5a8f382b7bf7eb4164fccfc1b
generated: "2024-09-17T00:20:51.436479+03:00"
2 changes: 1 addition & 1 deletion charts/victoria-metrics-operator/templates/_helpers.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Expand the name of the chart.
{{- define "vm-operator.cleanup.annotations" -}}
"helm.sh/hook": pre-delete
"helm.sh/hook-weight": "{{ .hookWeight }}"
"helm.sh/hook-delete-policy": before-hook-creation,hook-succeeded
"helm.sh/hook-delete-policy": before-hook-creation
{{- end }}

{{/*
Expand Down
5 changes: 2 additions & 3 deletions charts/victoria-metrics-operator/templates/service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,9 @@ spec:
{{- end }}
ports:
- name: http
port: 8080
port: {{ .Values.service.servicePort }}
targetPort: http
protocol: TCP
- name: webhook
port: 9443
- name: {{ .Values.service.webhookPort }}
targetPort: webhook
selector: {{ include "vm-operator.selectorLabels" . | nindent 4 }}
2 changes: 2 additions & 0 deletions charts/victoria-metrics-operator/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,8 @@ service:
externalTrafficPolicy: ""
ipFamilyPolicy: ""
ipFamilies: []
servicePort: 8080
webhookPort: 9443

# -- See `kubectl explain poddisruptionbudget.spec` for more or check [these docs](https://kubernetes.io/docs/tasks/run-application/configure-pdb/)
podDisruptionBudget:
Expand Down
Loading