minor fix

charts/victoria-metrics-cluster/README.md

@@ -451,7 +451,7 @@ name: ""
 </code>
 </pre>
 </td>
-      <td><p>Enable deployment of vmauth component. Deployment is used</p>
+      <td><p>Enable deployment of vmauth component. With vmauth enabled please set <code>service.clusterIP: None</code> and <code>service.type: ClusterIP</code> for <code>vminsert</code> and <code>vmselect</code> to use vmauth balancing benefits.</p>
 </td>
     </tr>
     <tr>

charts/victoria-metrics-cluster/templates/_helpers.tpl

@@ -100,7 +100,10 @@ app: {{ $Values.vmauth.name | default "vmauth" }}
   {{- if and (not $app.suppressStorageFQDNsRender) (and $storage.enabled $storage.replicaCount) }}
     {{- $storageNodes := default list }}
     {{- $fqdn := include "vm.fqdn" . }}
-    {{- if and $Values.autoDiscovery (eq (include "vm.enterprise.disabled" . ) "false") }}
+    {{- if $Values.autoDiscovery }}
+      {{- if (include "vm.enterprise.disabled" . ) "true" }}
+        {{- fail "SRV autodiscovery is only supported in enterprise. Either define license or set `autoDiscovery` to `false`" }}
+      {{- end }}
       {{- $storageNode := printf "srv+_vminsert._tcp.%s" $fqdn }}
       {{- $storageNodes = append $storageNodes $storageNode }}
     {{- else }}
@@ -143,7 +146,10 @@ app: {{ $Values.vmauth.name | default "vmauth" }}
   {{- if and (not $app.suppressStorageFQDNsRender) (and $storage.enabled $storage.replicaCount) }}
     {{- $storageNodes := default list }}
     {{- $fqdn := include "vm.fqdn" . }}
-    {{- if and $Values.autoDiscovery (eq (include "vm.enterprise.disabled" . ) "false") }}
+    {{- if $Values.autoDiscovery }}
+      {{- if (include "vm.enterprise.disabled" . ) "true" }}
+        {{- fail "SRV autodiscovery is only supported in enterprise. Either define license or set `autoDiscovery` to `false`" }}
+      {{- end }}
       {{- $storageNode := printf "srv+_vmselect._tcp.%s" $fqdn }}
       {{- $storageNodes = append $storageNodes $storageNode }}
     {{- else }}
@@ -161,7 +167,10 @@ app: {{ $Values.vmauth.name | default "vmauth" }}
     {{- $selectNodes := default list }}
     {{- $_ := set . "appKey" "vmselect" }}
     {{- $fqdn := include "vm.fqdn" . }}
-    {{- if and $Values.autoDiscovery (eq (include "vm.enterprise.disabled" . ) "false") }}
+    {{- if $Values.autoDiscovery }}
+      {{- if (include "vm.enterprise.disabled" . ) "true" }}
+        {{- fail "SRV autodiscovery is only supported in enterprise. Either define license or set `autoDiscovery` to `false`" }}
+      {{- end }}
       {{- $selectNode := printf "srv+_http._tcp.%s" $fqdn }}
       {{- $selectNodes = append $selectNodes $selectNode }}
     {{- else }}

charts/victoria-metrics-cluster/values.yaml

@@ -583,7 +583,8 @@ vminsert:
     metricRelabelings: []
 
 vmauth:
-  # -- Enable deployment of vmauth component. Deployment is used
+  # -- Enable deployment of vmauth component.
+  # With vmauth enabled please set `service.clusterIP: None` and `service.type: ClusterIP` for `vminsert` and `vmselect` to use vmauth balancing benefits.
   enabled: false
   # -- VMAuth container name
   name: ""