[victoria-metrics-alert] Fix alertmanager using server's values (#898)

VictoriaMetrics · Feb 27, 2024 · a9a969f · a9a969f
1 parent 5ac9504
commit a9a969f
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/charts/victoria-metrics-agent/README.md b/charts/victoria-metrics-agent/README.md
@@ -293,7 +293,7 @@ Change the values according to the need of the environment in ``victoria-metrics
 | extraVolumeMounts | list | `[]` |  |
 | extraVolumes | list | `[]` |  |
 | fullnameOverride | string | `""` |  |
-| horizontalPodAutoscaling | object | `{"enabled":false,"maxReplicas":10,"metrics":[],"minReplicas":1}` | Horizontal Pod Autoscaling. Note that it is not indended to be used for vmagents which perform scraping. In order to scale scraping vmagents see: https://docs.victoriametrics.com/vmagent/#scraping-big-number-of-targets |
+| horizontalPodAutoscaling | object | `{"enabled":false,"maxReplicas":10,"metrics":[],"minReplicas":1}` | Horizontal Pod Autoscaling. Note that it is not intended to be used for vmagents which perform scraping. In order to scale scraping vmagents see: https://docs.victoriametrics.com/vmagent/#scraping-big-number-of-targets |
 | horizontalPodAutoscaling.enabled | bool | `false` | Use HPA for vmagent |
 | horizontalPodAutoscaling.maxReplicas | int | `10` | Maximum replicas for HPA to use to to scale vmagent |
 | horizontalPodAutoscaling.metrics | list | `[]` | Metric for HPA to use to scale vmagent |

diff --git a/charts/victoria-metrics-alert/CHANGELOG.md b/charts/victoria-metrics-alert/CHANGELOG.md
@@ -3,6 +3,7 @@
 ## Next release
 
 - Fix possible null value on flag `notifier.url`, `remoteRead.url` and `remoteWrite.url` in vmalert deployment.
+- Fix alertmanager using some of server's values in its deployment template.
 
 ## 0.9.1
 

diff --git a/charts/victoria-metrics-alert/templates/alertmanager-deployment.yaml b/charts/victoria-metrics-alert/templates/alertmanager-deployment.yaml
@@ -98,13 +98,13 @@ spec:
             - name: config
               mountPath: /config
               readOnly: true
-            {{- range .Values.server.extraHostPathMounts }}
+            {{- range .Values.alertmanager.extraHostPathMounts }}
             - name: {{ .name }}
               mountPath: {{ .mountPath }}
               subPath: {{ .subPath }}
               readOnly: {{ .readOnly }}
             {{- end }}
-            {{- with .Values.server.extraVolumeMounts }}
+            {{- with .Values.alertmanager.extraVolumeMounts }}
             {{- toYaml . | nindent 12 }}
             {{- end }}
           resources:
@@ -119,7 +119,7 @@ spec:
       {{- if .Values.alertmanager.priorityClassName }}
       priorityClassName: {{ .Values.alertmanager.priorityClassName | quote }}
       {{- end }}
-      {{- with .Values.server.affinity }}
+      {{- with .Values.alertmanager.affinity }}
       affinity:
         {{ toYaml . | nindent 8 }}
       {{- end }}