♻️ Revert to the Original Implementation of ERC721 #1335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kadenzipfel can you please again review it. |
Vectorized
approved these changes
Feb 1, 2025
|
@atarpara also update the zksync variant hehe |
|
In halmos we trust. |
|
I assume this is being reverted due to the low likelihood of the issue occurring in practice? If so, I don't see any other issue with this logic, but I would recommend at least adding some documentation to explain the circumstance where the overflow check can fail Fwiw I think it's worth it to have the extra safe overflow check, especially since I think it only saves about 3 gas |
|
@kadenzipfel The overflow check will never fail.
|
Big oof lol. Guess we're all good then! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reverts #1245 changes
Checklist
Ensure you completed all of the steps below before submitting your pull request:
forge fmt?forge test?Pull requests with an incomplete checklist will be thrown out.