Fixes sleeping incapacitation runtime, minor code cleanup while I'm here #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tontyGH
added
code maintenance
Golubian
pushed a commit
to Golubian/Vanderlin
that referenced
this pull request
Feb 14, 2025
…ere (Vanderlin-Tales-Of-Wine#727) ## About The Pull Request `/datum/status_effect/incapacitating/sleeping` had a logic error which made it clear owner variables before running `on_remove()`, causing a runtime. This fixes that runtime while also doing minor code cleanup while I was looking at it ## Why It's Good For The Game 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
/datum/status_effect/incapacitating/sleepinghad a logic error which made it clear owner variables before runningon_remove(), causing a runtime. This fixes that runtime while also doing minor code cleanup while I was looking at itWhy It's Good For The Game