BUFFS maille armor values #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes maille armor. It now no longer the worst armor in the game.
|
not sure why this was changed to "buff" since this is a literal fix to the hell that is maille |
It is not broken... it is underpowered |
Golubian
pushed a commit
to Golubian/Vanderlin
that referenced
this pull request
Feb 14, 2025
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- Note: PRs including balance changes authored by anyone other than maintainers and official devs will not be considered. --> ## About The Pull Request <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review or prevent the PR from being merged! --> All this does is make Maille armor no longer the worst armor in the game. This was likely not by design but by oversight. It was weaker than the literal define for "weak" armor. It did not follow any logic. ## Why It's Good For The Game <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> Makes maille armor follow the logical progression shown in other armor categories. It now is no longer the worst armor in the game. ## Pre-Merge Checklist <!-- Don't bother filling these in while creating your Pull Request, just click the checkboxes after the Pull Request is opened and you are redirected to the page. --> - [x] You tested this on a local server. - [x] This code did not runtime during testing. - [x] You documented all of your changes. <!-- Neither the compiler nor workflow checks are perfect at detecting runtimes and errors. It is important to test your code/feature/fix locally. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
All this does is make Maille armor no longer the worst armor in the game. This was likely not by design but by oversight. It was weaker than the literal define for "weak" armor. It did not follow any logic.
Why It's Good For The Game
Makes maille armor follow the logical progression shown in other armor categories. It now is no longer the worst armor in the game.
Pre-Merge Checklist