Speech Fomatting (PORT) #663
Conversation
There was a problem hiding this comment.
Not fond of the implementation for emphasis... It's very messy and hard to follow. Having the same symbol / have 3 different uses might also make it unwieldy for users.
We should just port TG's emphasis implementation instead as it's way cleaner. No point in re-inventing the wheel.
| //allow player to format their speech | ||
| message = replacetextEx(message, regex(@"^([/+]*)(.*?)([/+]*)$"), /proc/format_dialogue) | ||
|
|
There was a problem hiding this comment.
A bit early, no? There's still quite a bit of parsing to go through.
There was a problem hiding this comment.
could be, can´t claim to understand this code, just tested if it did what it said on the tin and it did.
|
Could we make this consistent with SS13 in terms of formatting? Otherwise, lovely addition. |
Haven´t been able to do this, but perhaps someone else is. Would make sense to keep commands consistent. |
Would you be alright if I made an alternative PR with TG's implementation then? Or would you prefer to redo this one |
Of course, go right ahead! I´ll close this as soon you put yours up. |
|
About The Pull Request
Ports the Formatting from https://github.com/sylphynford/Penumbra/pull/110/files
Looks like this
So / word / for cursive, //other// for thick
Also reminder you can sing by putting % in front of words, for all the bards.
The Blackstone branch refactored their speech code somewhat at some point, possibly worth considering adopting the whole thing, then again maybe not. This works independently at least. Had to include the autopunctuation from Azure to keep it consistent, works too.
Pre-Merge Checklist