Prayer "refactor", patrons handle them now (+ underworld prayers) #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tontyGH
commented
Feb 1, 2025
tontyGH
changed the title
SingingSpock
reviewed
Feb 6, 2025
|
|
||
| /datum/patron/psydon/can_pray(mob/living/carbon/human/follower) | ||
| //We just kind of assume the follower is a human here | ||
| if(istype(follower.wear_neck, /obj/item/clothing/neck/roguetown/psycross)) |
There was a problem hiding this comment.
It should also check elsewhere, like the wrists... that's where Inquisitors start with theirs. They currently have to awkwardly move it to their necks for a brief moment to pray.
tontyGH
commented
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Prayers have been refactored so that most prayer behavior is handled by the patron
This means patrons can define their own requirements for prayers, handle hearing them differently
and can respond to rewards differently.
Additonally, there is now a new signal,
COMSIG_CARBON_PRAY, which can be registered and provide custom prayer handlingAlso includes some minor semi-related cleanup
Underworld Prayers
Spirits were seemingly supposed to be able to pray in the underworld, and would gain special behaviour
However, a logic error in the prayer proc made it so that spirits couldn't pray,
This fixes that, and makes underworld prayers be handled by the underworld area.
Why It's Good For The Game
Stuff like this shouldn't be hard-coded, and patrons should handle stuff that relates to them.
This makes the code a bit more flexible and allows us to make patrons more interesting.
Pre-Merge Checklist