-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ESP32] Add Hardware Version detection #203
Comments
Oh! This also fixes the fact that squelch never closes on v2.0 hardware. The squelch detect pin changed in v2.0; we need to detect the hardware version to make this software change. |
Oops. This is a dupe of #122. |
#205 is the PR for this. |
Hi @SmittyHalibut @VanceVagell Also, if the hardware version were displayed in the UI, it would be easier to detect and troubleshoot issues like this. 😉 |
* ADC_ATTEN_DB_12 is only defined in some versions? #198 * Hardware version detection. Fix v2.0 always-open squelch. #203 * Hardware version detection. Fix v2.0 always-open squelch. #203 * Cleaning formating/indenting from merge wackiness. No symantic changes. #203 * Added NeoPixel support. #207 * Removed dependency on Adafruit NeoPixel. Added breathing. #207 #208 * Cleanup proposal * Pedantic integer math changes. Explicit uint16_t cast, fix "color-1". #208 * #208 (review) #208 --------- Co-authored-by: Dmitry Kaukov <dkaukov@opentable.com>
Read Sense_VP and Sense_VN, they're either HIGH or LOW.
The original intent was to also use Hi-Z as a detectable state by setting internal pull-ups and pull-downs, but the Sensor pins don't have output drive hardware. So we're stuck with external drives.
The good news is, they are analog pins, so we can provide analog voltages with voltage dividers to provide more states going forward. For now, we're just going to use HIGH and LOW.
The text was updated successfully, but these errors were encountered: