Need help adding a conditional keybinding to an existing menu, not sure how to do so based on documentation

[macintacos]

Hello! I'm following this documentation section about overriding conditional bindings, and it's not immediately obvious to me how to do so so I wanted to open an issue about it.

Let's say have a command foo.bar that I want to add to the x submenu for major mode for the Markdown language. How would I go about adding that to my settings? Lets say I want to map it to be SPC m x k, since that's something I'm actively having trouble getting set up, but it honestly doesn't really matter what it is - I don't want to replace anything that is currently there, I just want to add a new command to the menu. How would I do that?

Once I get clarity here, I'll propose some changes to the documentation, because the way it's currently written doesn't make it very explicit how to go about this (at least for me). Thanks!

[stevenguh]

I assume SPC m x is a sub menu already exists, and you are just adding k to it. The following json should work, and you can change languageId:javascript to your condition.

{
  "whichkey.bindingOverrides": [
    {
      "keys": ["m", "languageId:javascript", "x", "k"],
      "name": "foo bar",
      "type": "command",
      "command": "foo.bar",
    }
  ]
}

I guess this section https://vspacecode.github.io/docs/extra#overrides can be improved?

[macintacos]

Ugh of course it was just the ordering I messed up! For whatever reason I was thinking that the "x","k" would come before the languageId (so "m", "x", "k", "languageId:markdown" instead of what you provided). If that's the intended ordering then yeah I think the documentation should be improved, if only to give that kind of example. I'll open a PR soonish to get that in there, thanks!