Modbustk error handler doesn't include .message #3178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update readthedocs requirements.txt * Update conf.py * Update requirements_demo.txt Add missing pandas requirement for demo * work around for issue VOLTTRON#3154 * Fix for security issue VOLTTRON#3168 (VOLTTRON#3169) * Fix for security issue VOLTTRON#3168 * handling clean up errors in test * testing group commands in different test module * moved group and role test to different module * moved group and role test to different module * Added a cache for agent names since platform start * Fixes process overload from file events * fixed issue with variable definition. * Remove PersistentDict from web-user.json file. * Update admin_endpoints.py Handle behavior of removing PersistentDict * Update version to 9.0.1 --------- Co-authored-by: Chandrika Sivaramakrishnan <chandrika@pnnl.gov> Co-authored-by: Chandrika <schandrika@users.noreply.github.com> Co-authored-by: Andrew Rodgers <andrew@aceiotsolutions.com>
|
@davidraker please look at this |
davidraker
reviewed
May 15, 2024
There was a problem hiding this comment.
This checks out, and looks correct. My only question is why we are detecting the exception type in an if statement instead of adding a separate except blocks for ModbusError and AttributeError? I don't think there is a functional difference, but it would be a little cleaner, I think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes the error handler that relies on .message being set on Modbustk Exception handler. The Modbustk exception handler does not set message so this handler never would give an accurate error message.