Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Dockerfileでgenerate_licenses.pyが動作しない問題を修正 #1543

Merged

Conversation

sabonerune
Copy link
Contributor

内容

#1541 でdocker buildが落ちてしまうようになったので修正です。

その他

sys.executable -m piplicenses ...で呼び出すように変更します。
この方法なら少なくとも環境に起因する問題は起こらないはず。

pip-licensesのドキュメントに書かれていないことが唯一の不安点。

@sabonerune sabonerune requested a review from a team as a code owner March 2, 2025 14:11
@sabonerune sabonerune requested review from Hiroshiba and removed request for a team March 2, 2025 14:11
gemini-code-assist[bot]

This comment was marked as resolved.

gemini-code-assist[bot]

This comment was marked as resolved.

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

ドキュメントに書いてない

まあいつか動かなくなる可能性もありえるだろうな~という気はしますね!
けどまあそのときまた考えれば良さそう!

@Hiroshiba Hiroshiba enabled auto-merge March 2, 2025 14:44
@Hiroshiba Hiroshiba disabled auto-merge March 2, 2025 14:45
@Hiroshiba Hiroshiba changed the title FIX: Dockerfileでgenerate_licenses.pyが動作しない問題を修正 fix: Dockerfileでgenerate_licenses.pyが動作しない問題を修正 Mar 2, 2025
@Hiroshiba Hiroshiba added this pull request to the merge queue Mar 2, 2025
Merged via the queue into VOICEVOX:master with commit 0419522 Mar 2, 2025
5 checks passed
@sabonerune sabonerune deleted the fix/generate_licenses-for-dockerfile branch March 2, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants