Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: READMEの--voicevox_dirの指定方法を更新 #1532

Merged
merged 1 commit into from
Feb 23, 2025

Conversation

nanae772
Copy link
Contributor

内容

vv-engineまで指定しないと動かなかったので、ドキュメントもそのように更新しました。

CONTRIBUTING.mdのほうでは

VOICEVOX_DIR="C:/path/to/VOICEVOX/vv-engine" # 製品版 VOICEVOX ディレクトリ内の ENGINE のパス

とあったので、現在はこちらのほうが正確なのではないかと思い、そのようにしました。

https://github.com/VOICEVOX/voicevox_engine/blob/master/CONTRIBUTING.md#%E9%9F%B3%E5%A3%B0%E3%83%A9%E3%82%A4%E3%83%96%E3%83%A9%E3%83%AA%E3%81%AB%E8%A3%BD%E5%93%81%E7%89%88-voicevox-%E3%82%92%E5%88%A9%E7%94%A8%E3%81%97%E3%81%A6%E5%AE%9F%E8%A1%8C

関連 Issue

スクリーンショット・動画など

その他

vv-engineまで指定しないと動かなかったので
@nanae772 nanae772 requested a review from a team as a code owner February 23, 2025 09:29
@nanae772 nanae772 requested review from Hiroshiba and removed request for a team February 23, 2025 09:29
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

README側にも残ってましたか、気づいてなかったので助かりました!!

@Hiroshiba Hiroshiba enabled auto-merge February 23, 2025 15:07
@Hiroshiba Hiroshiba added this pull request to the merge queue Feb 23, 2025
Merged via the queue into VOICEVOX:master with commit bc887f3 Feb 23, 2025
5 checks passed
@nanae772 nanae772 deleted the update-readme-voicevox-dir branch February 23, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants