Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependencies vendoring, part 1 #1228

Merged
merged 7 commits into from
Jan 31, 2025
Merged

dependencies vendoring, part 1 #1228

merged 7 commits into from
Jan 31, 2025

Conversation

PetrShumilov
Copy link
Contributor

@PetrShumilov PetrShumilov commented Jan 27, 2025 •
edited
Loading

Added as third-party

  • CURL 7.6 (libcurl.a)
  • OpenSSL 1.1.1 (libcrypto.a and libssl.a)

Also, the flex is picked up directly from KPHP artifacts, not from system

@PetrShumilov PetrShumilov added enhancement New feature or request runtime Feature related to runtime CI/CD labels Jan 27, 2025
@PetrShumilov PetrShumilov added this to the next milestone Jan 27, 2025
@PetrShumilov PetrShumilov self-assigned this Jan 27, 2025
@PetrShumilov PetrShumilov requested a review from a team as a code owner January 27, 2025 17:18
@PetrShumilov PetrShumilov force-pushed the pshumilov/dependency_vendoring_part1 branch 11 times, most recently from 3a5db1b to 78b94b6 Compare January 28, 2025 10:20
se-fedorov
se-fedorov previously approved these changes Jan 28, 2025
View reviewed changes
@PetrShumilov PetrShumilov force-pushed the pshumilov/dependency_vendoring_part1 branch 3 times, most recently from f1d2295 to ba87ed6 Compare January 28, 2025 10:32
@PetrShumilov PetrShumilov marked this pull request as draft January 28, 2025 11:54
@PetrShumilov PetrShumilov force-pushed the pshumilov/dependency_vendoring_part1 branch 7 times, most recently from bec636f to a425fd9 Compare January 28, 2025 13:26
@PetrShumilov PetrShumilov force-pushed the pshumilov/dependency_vendoring_part1 branch from 4ab00e3 to d81d8f8 Compare January 30, 2025 20:10
@PetrShumilov PetrShumilov marked this pull request as ready for review January 30, 2025 20:10
@PetrShumilov
Add openssl and curl vendoring
352d93d 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
@PetrShumilov PetrShumilov force-pushed the pshumilov/dependency_vendoring_part1 branch from d81d8f8 to 914767a Compare January 30, 2025 20:14
@PetrShumilov
Fix github CI
ae93538 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
@PetrShumilov
Suppress false-positive warining caused by O3 on gcc-8.3
3b5506b 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
@PetrShumilov PetrShumilov force-pushed the pshumilov/dependency_vendoring_part1 branch from 232bea6 to 3b5506b Compare January 30, 2025 20:27
@PetrShumilov
Disable debug-info
31c6dbc 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
st1ckyf1ng4z
st1ckyf1ng4z previously approved these changes Jan 31, 2025
View reviewed changes
apolyakov
apolyakov requested changes Jan 31, 2025
View reviewed changes
cmake/popular-common.cmake Outdated Show resolved Hide resolved
common/crypto/aes256-generic.cpp Show resolved Hide resolved
@PetrShumilov
Use conservative optimization level
71b531d 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
@PetrShumilov
Return the linking flex as system-installed lib by default
7e7b346 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
@PetrShumilov
Make order of includes correct
93c3027 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
@PetrShumilov PetrShumilov merged commit be4e6c8 into master Jan 31, 2025
5 checks passed
@PetrShumilov PetrShumilov deleted the pshumilov/dependency_vendoring_part1 branch January 31, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@se-fedorov se-fedorov se-fedorov approved these changes

@DrDet DrDet DrDet approved these changes

@promo4ka promo4ka promo4ka approved these changes

@apolyakov apolyakov apolyakov approved these changes

@mkornaukhov03 mkornaukhov03 Awaiting requested review from mkornaukhov03

@astrophysik astrophysik Awaiting requested review from astrophysik

@st1ckyf1ng4z st1ckyf1ng4z Awaiting requested review from st1ckyf1ng4z

Assignees

@PetrShumilov PetrShumilov

Labels
CI/CD enhancement New feature or request runtime Feature related to runtime
Projects
None yet
Milestone
next
Development

Successfully merging this pull request may close these issues.
6 participants
@PetrShumilov @apolyakov @promo4ka @st1ckyf1ng4z @DrDet @se-fedorov