apply updated code style #1196
apply updated code style #1196
Conversation
.git-blame-ignore-revs
Outdated
There was a problem hiding this comment.
after squash, there will be another sha commit. .git-blame-ignore-revs should be added after the merge of this MR
There was a problem hiding this comment.
Yes, it's added here so you can test it and make sure that git blame continues working
| @@ -3,12 +3,12 @@ | |||
| #include "common/smart_ptrs/intrusive_ptr.h" | |||
|
|
|||
| #ifndef INCLUDED_FROM_KPHP_CORE | |||
| #error "this file must be included only from runtime-core.h" | |||
| #error "this file must be included only from runtime-core.h" | |||
There was a problem hiding this comment.
don't want to enable `IndentPPDirectives'?
There was a problem hiding this comment.
+1 for macro indentation
| AllowAllParametersOfDeclarationOnNextLine: true | ||
| AllowShortBlocksOnASingleLine: false | ||
| AllowShortCaseLabelsOnASingleLine: false | ||
| AllowShortFunctionsOnASingleLine: Empty |
There was a problem hiding this comment.
maybe we should keep it?
| ReflowComments: true | ||
| SortIncludes: true | ||
| SpaceAfterCStyleCast: false | ||
| SpaceAfterTemplateKeyword: false |
There was a problem hiding this comment.
Includes are sorted implicitly by setting base variant on LLVM, I suppose.
| IncludeCategories: | ||
| - Regex: '^<' | ||
| Priority: 1 | ||
| IndentCaseLabels: true |
There was a problem hiding this comment.
maybe we should keep it?
There was a problem hiding this comment.
Mb will we add the formatting script first, and then the new rules?
| @@ -3,12 +3,12 @@ | |||
| #include "common/smart_ptrs/intrusive_ptr.h" | |||
|
|
|||
| #ifndef INCLUDED_FROM_KPHP_CORE | |||
| #error "this file must be included only from runtime-core.h" | |||
| #error "this file must be included only from runtime-core.h" | |||
There was a problem hiding this comment.
+1 for macro indentation
| ReflowComments: true | ||
| SortIncludes: true | ||
| SpaceAfterCStyleCast: false | ||
| SpaceAfterTemplateKeyword: false |
There was a problem hiding this comment.
Includes are sorted implicitly by setting base variant on LLVM, I suppose.
apolyakov
force-pushed
the
apolyakov/update-clang-format
branch
from
3736a14 to
6fcdf6f
Compare
apolyakov
force-pushed
the
apolyakov/update-clang-format
branch
2 times, most recently
from
3418219 to
fa623c6
Compare
apolyakov
force-pushed
the
apolyakov/update-clang-format
branch
from
fa623c6 to
e2ff8dc
Compare
|
|
||
| - name: Check for formatting changes | ||
| run: | | ||
| # Check if any files were modified by clang-format |
There was a problem hiding this comment.
why not git diff --exit-code?
apolyakov
force-pushed
the
apolyakov/update-clang-format
branch
from
03adca9 to
d113357
Compare
No description provided.