Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Storybook): fix double scroll in controls panel #8245

Merged

Conversation

EldarMuhamethanov
Copy link
Contributor

@EldarMuhamethanov EldarMuhamethanov commented Feb 6, 2025

Описание

Сейчас на вкладке Controls в сторибуке отображается двойной скролл
image
Нужно избавиться от двойного скролла

Изменения

Оказалось, чтоб проблема в том, что вкладка Source скрывается только визуально, но остается в верстке. А в стилях сторибука важные стили применяются только к первому элементу.
Получается есть два варианта решения проблемы:

  1. Перемещаем вкладку Source после Controls
  2. Не рендерим контент Source, если вкладка неактивна

Решил выбрать второй вариант, чтобы не менять порядок вкладок.

Результат:
image

Release notes

Документация

  • В storybook исправлен двойной скролл во вкладке Controls

@EldarMuhamethanov EldarMuhamethanov self-assigned this Feb 6, 2025
@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner February 6, 2025 09:14
@github-actions github-actions bot added the patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Feb 6, 2025
Copy link

codesandbox-ci bot commented Feb 6, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.53%. Comparing base (4f2d7c0) to head (1fbea4c).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8245   +/-   ##
=======================================
  Coverage   95.53%   95.53%           
=======================================
  Files         404      404           
  Lines       11553    11553           
  Branches     3836     3836           
=======================================
  Hits        11037    11037           
  Misses        516      516           
Flag Coverage Δ
unittests 95.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Feb 6, 2025

👀 Docs deployed

Commit 1fbea4c

@EldarMuhamethanov EldarMuhamethanov merged commit fcf48ad into master Feb 6, 2025
19 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the e.muhamethanov/fix-controls-double-scroll branch February 6, 2025 17:02
@EldarMuhamethanov EldarMuhamethanov added this to the v7.1.3 milestone Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча technical task
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants