Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: FormItem noPadding with removable #8232

Merged

Conversation

SevereCloud
Copy link
Contributor

@SevereCloud SevereCloud commented Feb 3, 2025

  • Unit-тесты
  • e2e-тесты
  • Дизайн-ревью
  • Документация фичи
  • Release notes

Описание

Компонент FormItem c noPadding removable имел лишний отступ

<FormItem noPadding removable >...</FormItem>

Изменения

В removable передается свойство noPadding которое отключает отступ для базовой темы. Для iOS отступ остается из-за особенностей работы удаления в iOS

Release notes

Исправление

  • FormItem: при noPadding и removable был лишний отступ

@SevereCloud SevereCloud requested a review from a team as a code owner February 3, 2025 13:53
@SevereCloud SevereCloud self-assigned this Feb 3, 2025
@SevereCloud SevereCloud added this to the v7.1.3 milestone Feb 3, 2025
@github-actions github-actions bot added the patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Feb 3, 2025
Copy link

codesandbox-ci bot commented Feb 3, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Feb 3, 2025

size-limit report 📦

Path Size
JS 394.15 KB (+0.02% 🔺)
JS (gzip) 119.54 KB (+0.02% 🔺)
JS (brotli) 98.42 KB (+0.08% 🔺)
JS import Div (tree shaking) 1.56 KB (0%)
CSS 347.53 KB (+0.01% 🔺)
CSS (gzip) 43.02 KB (+0.01% 🔺)
CSS (brotli) 34.31 KB (+0.04% 🔺)

@SevereCloud SevereCloud force-pushed the SevereCloud/fix/FormItem-noPadding-with-removable branch from 61d744f to 1cd0266 Compare February 3, 2025 13:58
Copy link
Contributor

github-actions bot commented Feb 3, 2025

e2e tests

Playwright Report

Copy link
Contributor

github-actions bot commented Feb 3, 2025

👀 Docs deployed

Commit 1cd0266

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.51%. Comparing base (d0fb8bd) to head (1cd0266).
Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8232   +/-   ##
=======================================
  Coverage   95.51%   95.51%           
=======================================
  Files         404      404           
  Lines       11531    11536    +5     
  Branches     3830     3830           
=======================================
+ Hits        11014    11019    +5     
  Misses        517      517           
Flag Coverage Δ
unittests 95.51% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SevereCloud SevereCloud merged commit 0ca9ed9 into master Feb 5, 2025
29 checks passed
@SevereCloud SevereCloud deleted the SevereCloud/fix/FormItem-noPadding-with-removable branch February 5, 2025 09:32
@vkcom-publisher
Copy link
Contributor

❌ Patch

Не удалось автоматически применить исправление на ветке 7.1-stable.

Дальнейшие действия выполняют контрибьютеры из группы @VKCOM/vkui-core

Чтобы изменение попало в ветку 7.1-stable, выполните следующие действия:

  1. Создайте новую ветку от 7.1-stable и примените изменения используя cherry-pick
git stash # опционально
git fetch origin 7.1-stable
git checkout -b patch/pr8232 origin/7.1-stable

git cherry-pick --no-commit 0ca9ed9fb139f917e6f020029ae64874415ee63a
git checkout HEAD **/__image_snapshots__/*.png
git diff --quiet HEAD || git commit --no-verify --no-edit
  1. Исправьте конфликты, следуя инструкциям из терминала
  2. Отправьте ветку на GitHub и создайте новый PR с веткой 7.1-stable (установка лейбла не требуется!)
git push --set-upstream origin patch/pr8232
gh pr create --base 7.1-stable --title "patch: pr8232" --body "- patch #8232"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants