-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: FormItem noPadding with removable #8232
fix: FormItem noPadding with removable #8232
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
size-limit report 📦
|
61d744f
to
1cd0266
Compare
e2e tests |
👀 Docs deployed
Commit 1cd0266 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8232 +/- ##
=======================================
Coverage 95.51% 95.51%
=======================================
Files 404 404
Lines 11531 11536 +5
Branches 3830 3830
=======================================
+ Hits 11014 11019 +5
Misses 517 517
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
❌ PatchНе удалось автоматически применить исправление на ветке 7.1-stable.
Чтобы изменение попало в ветку 7.1-stable, выполните следующие действия:
git stash # опционально
git fetch origin 7.1-stable
git checkout -b patch/pr8232 origin/7.1-stable
git cherry-pick --no-commit 0ca9ed9fb139f917e6f020029ae64874415ee63a
git checkout HEAD **/__image_snapshots__/*.png
git diff --quiet HEAD || git commit --no-verify --no-edit
git push --set-upstream origin patch/pr8232
gh pr create --base 7.1-stable --title "patch: pr8232" --body "- patch #8232" |
Unit-тестыДизайн-ревьюОписание
Компонент FormItem c noPadding removable имел лишний отступ
Изменения
В removable передается свойство noPadding которое отключает отступ для базовой темы. Для iOS отступ остается из-за особенностей работы удаления в iOS
Release notes
Исправление
noPadding
иremovable
был лишний отступ